> On Nov 16, 2016, at 11:15 PM, Mark Williams <markrwilli...@gmail.com> wrote: > > On Thu, Nov 10, 2016 at 07:56:52PM +1100, Amber "Hawkie" Brown wrote: >> - Python 3 support for Words' IRC support and twisted.protocols.sip among >> some smaller modules, > > I have opened a PR to revert this: > > https://github.com/twisted/twisted/pull/593 > > A full explanation is here: > > https://twistedmatrix.com/trac/ticket/6320#comment:16 > > In summary: a valid IRC message will cause a UnicodeDecodeError within > the event loop that a user cannot handle or avoid, and all length > checks on line sizes are wrong because they occur prior to encoding to > utf-8.
Reverts should be commits that go straight to trunk and reopen tickets, per the current process. However; is it really a regression to have py3 support for Words that just doesn't support other encodings yet? It strikes me that this is just a bug, and that we should just fall back from UTF-8 to latin-1 in this scenario. But adding that fallback is a small additional fix (perhaps one that should be slated for 16.6.0 if you want to make it). -glyph _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
