In that case, should there be a patch that skips that for v2? Or perhaps just raise an error for versions < v2 if the function does not return a list? Of course, this wouldn't be backwards compatible which might be problematic.
On Thu, Jan 31, 2013 at 1:45 PM, Laurens Van Houtven <_...@lvh.cc> wrote: > On Thu, Jan 31, 2013 at 4:43 PM, Matthew Williams <mgwilli...@gmail.com>wrote: > >> I have a couple questions regarding txjsonrpc ( >> https://github.com/oubiwann/txjsonrpc/) in connection with the recent >> addition of version 2.0 support. >> >> * How complete is the version 2.0 support? I had actually tried some >> years ago to add v2.0 support, but gave up due to some issues I no longer >> fully recall. Are there any known issues with the present implementation? >> > > Not that I know of. > > >> * I noticed that all results are wrapped in an array (see netstring >> version at >> https://github.com/oubiwann/txjsonrpc/blob/master/txjsonrpc/netstring/jsonrpc.py#L63-L64, >> but the web implementation has the same code.). This seems odd, as a >> jsonrpc result can be any valid json value, including a string, integer, >> array, or dict. The result is that on the client end, what I return from >> the function call as {"a": "b"} is received as [{"a": "b"}]. Is there some >> reason for this? Would a patch altering this behavior (perhaps optionally) >> be accepted? >> > > Huh, that's weird. I knew the params had to be an array in some version of > JSONRPC (although this limitation appears to have been lifted right now). I > can't find anything like that in the spec, so I do wonder why that was ever > added :) > > >> Thanks in advance for any help on these two questions. >> >> Matthew Williams >> >> _______________________________________________ >> Twisted-Python mailing list >> Twisted-Python@twistedmatrix.com >> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python >> >> > > > -- > cheers > lvh > > _______________________________________________ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > >
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
