On Feb 9, 2012, at 8:57 AM, Jonathan Lange wrote: > On Thu, Feb 9, 2012 at 1:54 PM, <exar...@twistedmatrix.com> wrote: >> On 12:09 pm, j...@mumak.net wrote: >>> On Thu, Feb 9, 2012 at 12:30 AM, <exar...@twistedmatrix.com> wrote: >>>> On 8 Feb, 10:15 pm, j...@mumak.net wrote: >>>>> >>>>>> From the documentation: >>>>> >>>>> * Trial spins the reactor a couple of times before cleaning it up, >>>>> ``AsynchronousDeferredRunTest`` does not. If you rely on this >>>>> behavior, use >>>>> ``AsynchronousDeferredRunTestForBrokenTwisted``. >>>> >>>> I've expected for some time now that we would deprecate this behavior >>>> in >>>> twisted.trial.unittest.TestCase. Just a matter of someone getting to >>>> it. >>> >>> Yeah. I think the last time I tried there were just too many broken >>> test cases in Twisted itself, which made the exercise quite daunting. >> >> Fortunately it lends itself quite well to incremental change. One can >> generally meaningfully fix a single unit test/test case at a time. :) >> > > Right. At the time it was discouraging because I felt like there were > a hundred tests to fix one at a time, then add the deprecation warning > and then a year later get to my actual goal of removing the extra > iterates. I don't feel that way any more.
This is also a great exercise for a Twisted contributing beginner, at least, if they have some help and guidance from a mentor familiar with the issues involved. If anyone out there is on the fence about getting involved with the project and looking for an on-ramp that involves manageable chunks of work, test maintenance fixes like these are a great place to get started. -glyph _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python