On Mon, Apr 4, 2011 at 10:55 PM, <[email protected]> wrote: >> >>So, now I am curious why this copyright.py patch is required? > > It's required because of restrictions on what version you are allowed to > use when building an MSI. These rules are codified in > distutils.version.StrictVersion: > > >>> from distutils.version import StrictVersion > >>> from twisted import __version__ > >>> StrictVersion(__version__) > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > File "/usr/lib/python2.6/distutils/version.py", line 40, in > __init__ > self.parse(vstring) > File "/usr/lib/python2.6/distutils/version.py", line 107, in parse > raise ValueError, "invalid version number '%s'" % vstring > ValueError: invalid version number '11.0.0+r31541' > >>> StrictVersion('11.0.0pre1') > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > File "/usr/lib/python2.6/distutils/version.py", line 40, in > __init__ > self.parse(vstring) > File "/usr/lib/python2.6/distutils/version.py", line 107, in parse > raise ValueError, "invalid version number '%s'" % vstring > ValueError: invalid version number '11.0.0pre1' > > The build step is there to ensure the version is something bdist_msi > will accept. It's an unintentional side-effect that the change survives > all the way through to the built page.
I've tried to do this directly in setup.py so that local .msi builds could work too. http://twistedmatrix.com/trac/ticket/5024 -- anatoly t. _______________________________________________ Twisted-Python mailing list [email protected] http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
