On Thu, Jun 24, 2010 at 1:14 PM, Michael Hudson-Doyle <mica...@gmail.com> wrote: > On 9 June 2010 23:25, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: >> I think we should give screwtape an SVN account and make him an official >> reviewer. He's been doing a lot of work on the distutils code which would >> be made easier by that, and he's been doing pretty decent reviews. >> >> Thoughts? (Feel free to voice any comments off-list, too.) > > OK, so this is extreme pedantry but I didn't think Twisted had the > concept of official reviewer :-)
There seems to be a policy, although I'm not sure if this is actually written down anywhere, that for a branch/patch to be merged to trunk, either the author should be a committer, or (one of) the reviewer(s) should be a committer. So, I guess an "official" reviewer would just be someone with commit access? -- mithrandi, i Ainil en-Balandor, a faer Ambar _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
