On Tue, 27 Jan 2009 18:37:39 -0800, Michael Pyle <mpyle101+twis...@gmail.com>
wrote:
On Tue, 27 Jan 2009 19:08:15 -0000, gl...@divmod.com wrote:
[snip]
So the first thing you should do is find, file, and fix as many tickets as
you can related to warnings in tests; warnings from Twisted itself, warnings
from the stdlib, warnings from dependencies.
Is there a way you prefer to see the tickets entered? Looking at the
buildbot log for build 45 it seems like there's a few different ways to
slice and dice things depending on how granular you want the tickets. You
could do it by "fix deprecated calls" or narrow it down to "fix
DeprecationWarning for xxx" or break it up by module or even on a file by
file or call by call basis (granted the latter seems like overkill for a
porting effort).
You'll find some tickets already exist in the tracker. For example,
http://twistedmatrix.com/trac/ticket/3493
http://twistedmatrix.com/trac/ticket/3431
http://twistedmatrix.com/trac/ticket/3424
http://twistedmatrix.com/trac/ticket/3231
http://twistedmatrix.com/trac/ticket/3153
For other issues, I would lean towards filing a ticket per test_*.py file.
However, this is just a general rule of thumb. You may find it easy to fix
several test_*.py files at once with one set of changes, or you may find
that the fixes for one set of deprecations from a single test file are
totally unrelated to another set of fixes for other deprecations (cases in
which I would file just one ticket or multiple tickets, respectively). So
feel free to exercise your own judgment. We won't bite your head off if
we disagree with your decision, but we might ask you to split one patch
into two or more pieces.
One thing that's probably worth watching out for is that there are a couple
large, old Conch branches outstanding. Changes to Conch's test suite may
conflict with these branches. I wouldn't let this stop you from fixing
things in Conch, but it would probably be best to try to coordinate with
Paul Swartz before digging in too deeply.
Jean-Paul
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
