On Tuesday, December 9, 2014 3:40:03 PM UTC+5:30, Cédric Krier wrote: > > On 09 Dec 10:45, Pierre-Louis Bonicoli wrote: > > On 09/12/2014 01:21, Simon Klemenc wrote: > > > so just in case it becomes even more strict and there is no 8771002, > > > (please?) could you update the wiki, as its not obvious for the dumb > but > > > helpful folks... > > > maybe in the coding guidelines it could also be noted that %s is the > > > desired string-format format... > > > > Please, could a core developer list the coding guidelines ? A such list > > would allow faster contributions. > > http://code.google.com/p/tryton/wiki/CodingGuidelines > > > > http://codereview.tryton.org/12491002/ > > > (why not: "please dont fix flake8 from others, they are fixed with > 8771002") > > > I really dont want to be bashing but after reading 14761002 i just > fail > > > to see the point of doing open source without accepting different > > > opinions + i feel a little ashamed... > > > > Generally, in order to allow faster contributions, core developers > > should avoid writing opposite comments in review. Better reviews will > > result in better contributions. > > For example, in 12491002, comment in patch set 3 about "ValueError" > > could have been written in patch set 1, it would have avoided a patch > > set. Moreover this will avoid giving impression that contributions are > > not welcome. > > That's a dream. Or I will just stop reviewing. >
I am hoping that I have managed to be as annoying as you are for things which really don't matter as much in this pull request [1]. You gave up so fast, but other people like me trying to contribute to tryton usually give up only after a few more attempts of trying to communicate with you. Let us all be more welcoming to changes and contributions. Most people contribute only when they are happy about it - and sending a patch to you has not been the happier of things I get to do everyday (remember the design/styling of Sao I worked on ?). It is not difficult because, you are strict on coding standards, but the unnecessarily lengthy process and unwelcome approach. For a change, here are some fruitful thoughts on how to encourage people for contribution. * http://lostechies.com/derickbailey/2012/12/14/dear-open-source-project-leader-quit-being-a-jerk/ * https://github.com/JuliaLang/julia/issues/7794 [1] https://github.com/openlabs/tryton.us/pull/59#issuecomment-66270003
