On 20 Oct 13:32, Raimon Esteve wrote: > 2014-10-20 13:12 GMT+02:00 Cédric Krier <cedric.kr...@b2ck.com>: > > Hi, > > > > I created a blueprint for sale commission at > > https://code.google.com/p/tryton/wiki/CommissionModule > > And idea o base module about Sale Commission: > > https://bitbucket.org/nantic/trytond-sale_commission
I did not know about it but after a quick look, I have some issue with
its design:
- It creates supplier invoice for commission. For me, it is wrong.
Supplier invoice must be created only when the supplier really
send you an invoice.
- It is hardly linked to sale. I think commission could happen even
if there is no prior sale.
- The commission is computed on the invoice amount while I think
agent can have different commission (and even no commission)
depending of the product sold.
- It creates commission only when the invoice is paid (partially). I
think there are business where commission is due on invoice
posting.
- It doesn't create a hard link between commission and invoice.
- If the invoice is cancelled, the commission is not.
- It adds agent information on Party. I think it should be avoided
to bloat the party like that (especially the is_* boolean).
There are just one feature not in my design which is that it creates
commission on payment of a term (partial payment). But such feature
prevents to have commission base on product sold. So I don't think it is
really a key feature if you have commmission "On Posting" and "On
Payment".
--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric.kr...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
pgpWQjrXw9O4a.pgp
Description: PGP signature
