On 03 Sep 11:11, Simon Klemenc wrote: > Thanks for your comments ced, no doubt you know the best about trytond > internals. > > although i am perfectly fine to accept that not a piece of my work will > make it to upstream, > please let me > > > On Tuesday, September 2, 2014 11:07:44 PM UTC+2, Cédric Krier wrote: > > > > On 02 Sep 09:14, simon....@gmail.com <javascript:> wrote: > > > hi there, > > > > > > first thing, im sorry for doing this in reverse order: i have already > > > opened a codereview at http://codereview.tryton.org/10481002/ and am > > now > > > writing in here to state my motivation. > > > > > > > > > the reason i even took a deeper look at modules/__init__.py was that i > > > wanted to run tryton in a more project/framework oriented way: having a > > > project folder with tryton modules and my own modules, similar to how a > > > common django-project would look like. This would ease the process of > > > developing (getting started using sqlite straight away) and creating > > > docker-instances a lot for me. > > > > This is a wrong goal and will not land in Tryton because: > > > > - it does enforce uniqueness of module name > > > > Really, did you ever try to load more than one module with non-unique names? > I doubt you would ever succeed on this for quite some reasons: [including > links :) ]
It is by design! Directory names are *unique*. > - it is useless because modules can be registered via pkg_resources. > > > > > True. > but then i still have to add a setup.py and install using pip, which turns > out to be not soo simple to automate with docker.. Blame docker. > > > - the searching of module-paths happens a few times spread all over > > trytond (modules/__init__, tools/misc,..) > > > > Please show examples. > > > > > http://hg.tryton.org/trytond/file/f0e247a7b960/trytond/modules/__init__.py#l295 > http://hg.tryton.org/trytond/file/f0e247a7b960/trytond/modules/__init__.py#l334 > > -356 > http://hg.tryton.org/trytond/file/f0e247a7b960/trytond/monitor.py#l63 (its > not known, thats why many so many directories are searched - maybe not the > best example) > http://hg.tryton.org/trytond/file/f0e247a7b960/trytond/tools/misc.py#l83 So feel free to propose a refactoring. -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.kr...@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
pgpFKKhSWFqqr.pgp
Description: PGP signature
