On Monday 19 August 2013 17:53:27 Jan Kundrát wrote: > On Monday, 19 August 2013 17:06:55 CEST, Pali Rohár wrote: > > Code is in > > git://anongit.kde.org/clones/trojita/pali/trojita.git > > branch pali-gsoc. > > Hi Pavol, good job. I would like to review your changes one at > a time, though, or rather "one topic at a time". It seems to > me that your work can be split into these five categories: > > - Misc GUI fixes and other changes in preparation for "real > work"
There is missing: Plugin library which implement interface/API for plugins and access functions for Trojita GUI. > - Plugins for abook and for password storage > - Kontact integration > - IPC support and mailto handling > > Please pick one area to start with (I assume it will be the > one I mentioned first because other changes likely depend on > that), identify which commits belong to that category, and > submit them for review via RB -- one group at a time. I guess > you'll need to rebase on top of c430463 for the QSettings > changes. > > OK? > OK. I already started with first two: one qsettings instance and fix using application name/version. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
