On Wednesday 14 August 2013 19:52:02 Jan Kundrát wrote: > On Wednesday, 14 August 2013 17:29:37 CEST, Pali Rohár wrote: > > in my pali-gsoc branch there is IPC support via DBus. > > Trojita now export some functions via DBus: for opening > > main window, opening addressbook window and opening compose > > new mail window. > > Cool -- great to see that you're making a good progress. > > Does this work depend on what you've done plugin-wise? Right > now, the total diffstat between master and your branch are > 5381 added lines and 1994 removed ones; that's a *ton* of > code to carefuly go through. What I'd like to request is > having this work split into nice, atomic chunks which do not > include unrelated changes on top of each other. Could you > please do that, so that we can review one logical set of > changes at a time? >
I think not, IPC does not depend on plugin code. But IPC was added to kontact kpart plugin too, so now when you click on trojita icon in konact when some standalone instance is already running it will only bring trojita window to front. Ok, I can split & combine commits into patches in logical order. > > When trojita is starting first it checking if there is > > another instance already running. If yes it will use IPC to > > do something (open main window or compose new mail...). > > I made a quick look at how you do IPC. What surprised me was > that you chose to implement empty stub functions for IPC > instead of having the code #ifdefed -- why? > Now there is only support for DBus which not working on all platforms (it is used only on linux desktops?). So in future if somebody will add support for Windows, or Apple systems, it should be in separete files. #ifdef is not really good idea because some standard windows or apple IPC is totally different from DBus and code with full of #ifdef will not be readable... > > Trojita now support some command line arguments, mostly for > > specifing email headers for new email (to, cc, subject, > > body, ...) There is also support to pass mailto: url, but I > > looked into trojita code and there is limited support for > > mailto. Maybe this can be extended. > > When I investigated how to do --mailto handling some months > ago, I ended up reading through KDE's code to see how > kdelibs, kdepim and kmail handled this. IIRC there was some > special-casing for KMail for passing the subjects, addresses > etc via distinct params while all other MUAs were only given > an URL (with no loss of functionality) -- all of that is > "IIRC". Are the individual options needed? > Individual options can be usefull for user who do not know full mailto: syntax and want to start writing new mail from terminal. > > Kevin and how to tell KDE (or maybe other DE too) that > > trojita application is email client and mailto: argument > > can be passed via cmdline? > > I asked about this on the xdg mailing list, see the thread [1] > from November 2012. It should be just a matter of providing a > correct .desktop file (and maybe a dedicated binary like e.g. > `trojita-mailto-handler` or something). > > Cheers, > Jan > > [1] > http://lists.freedesktop.org/pipermail/xdg/2012-November/0125 > 73.html So will be this patch enough? Mailto url could be first argument. diff --git a/src/Gui/trojita.desktop b/src/Gui/trojita.desktop index bfdc5c2..9d74d02 100644 --- a/src/Gui/trojita.desktop +++ b/src/Gui/trojita.desktop @@ -56,9 +56,10 @@ GenericName[uk]=Поштовий клієнт IMAP GenericName[x-test]=xxIMAP E-mail Clientxx GenericName[zh_TW]=IMAP 電子郵件客戶端程式 TryExec=trojita -Exec=trojita +Exec=trojita %u Terminal=false Type=Application Icon=trojita Categories=Qt;Office;Network;Email; StartupNotify=true +MimeType=x-scheme-handler/mailto; -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
