On Thursday 20 June 2013 22:21:54 Jan Kundrát wrote: > On Thursday, 20 June 2013 21:13:17 CEST, Thomas Lübking wrote: > > The ignorelist is meant to have the addressbook skip entries > > already used in TO/CC/BCC/SENDER fields, what helps to limit > > the maximum of entries, thus the popup short, and get > > faster to the still relevant entries. > > That's a good idea (someone should update the comment and > implement it, though). > > >> I'm also slightly unsure about whether it should be changed > >> to a QList<QPair<QString, QString> > to pass the human > >> readable names and e-mail addresses separately. Opinions? > > > > +1 > > Allows to keep formatting in Trojitá (in case some absurd > > sender requires «» instead of <> or if we want to pass this > > through visual formatting that does not display <> but makes > > the human name bold or deconstrasts the mail or whatever) > > OK, agreed. >
Ok > > Makes me wonder whether the interface should have > > "isEditable()" and what to do if not? > > That's a goog idea as well -- Pali. could you please add that? > Hm, I think it is not needed. In plugin interface we need only function which open contact window. And there could be edit button or window will be itself editable (like kaddressbook or internal trojita addressbook). What about renaming that function to openContactWindow()? > > What about an error value system instead, ie. when the LDAP > > addressbook figures it does not work (no response in 500ms) > > it sets some error and signals completionAvailable. Trojita > > then clears the error and either tries the next plugin or > > resolves to some default? > > Looks like a job for the, well, Job interface, after all :) > > Cheers, > Jan I do not have any LDAP server, not know how LDAP working, what is needed for implementing LDAP client and also I do not planning this for GSoC. So it is hard for me to create interface for it. I think that if somebody will work on LDAP later, it will be possible to add new signals/jobs/methods to existing interface. Current interface only reflect what Trojita using (open addressbook window, open contact window, request for completion, ...) -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
