** Description changed: # Context Earlier this cycle, I synced lightdm, under the impression that the vast majority of the fixes were upstreamed: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6 This required a near-immediate followup upload: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6ubuntu1 And after some feedback, some additional configuration tweaks: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6ubuntu2 After close examination of the delta between the lightdm in 24.10 and Plucky, it seems I missed a few other elements, which are resurfacing in bugs like bug 2098411. It's time to clean this up and be more consistent with 24.10's lightdm. # Addressing Freezes If someone were to take a quick look at this diff, they might be hesitant to accept it. It might seem to break Feature Freeze. This being said, it does not. Allow me to explain why. Feature Freeze is only applicable to features as compared to the previous release. This is why source NEW packages are okay past Feature Freeze, because they don't add any features to existing packages, as compared to the previous release. In this specific case, the current state of lightdm has regressed in terms of featureset compared to Oracular. Restoring that featureset and providing a remedy for that regression, in and of itself, simply restores feature parity between the two releases. Care was taken so only the necessary parts of the Debian delta in Oracular are included. If, despite this rationale, you are still insistent on a Feature Freeze Exception, please consider this a non-conventional request. # QA and Testing Plan The following flavors are affected by this change: - Ubuntu Budgie - Ubuntu MATE - Ubuntu Unity - Ubuntu Cinnamon - Ubuntu Kylin - Xubuntu As part of the quality assurance for this change, I have personally tested all six flavors. As with any bug, I first established a baseline with 24.10, the "known good." I then tested with the current Plucky dailies, the "known bad." Finally, I tested with the newly-patched lightdm, which is, I suppose, the "newly-known good." 1. Simple smoke test: can you log in, log out, and log back in? - a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity - b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity - c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity + a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 2. Guest sessions are disabled. - a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity - b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity - c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity + a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 3. `XDG_*` is properly populated. - a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity - b. Known Bad: ✅ Budgie (known good), ✘ MATE, ✘ Unity - c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity + a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + b. Known Bad: ✅ Budgie (known good), ✘ MATE, ✘ Cinnamon, ✘ Kylin + c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 4. Invalid configuration files show a popup when attempting to start lightdm. - a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity - b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity - c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity + a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity, ✘ Cinnamon, ✘ Kylin + c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 5. logrotate is used (or at least recognized) instead of the built-in logging backup system. - a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity - b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity - c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity + a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin + b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity, ✘ Cinnamon, ✘ Kylin + c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin This would involve finding a way to crash, which is outside the scope of this bug report, but the apport hook was also added back. Therefore, I personally certify that I have tested this upload against all five manual QA points as described, and that no obvious regressions exist from smoke tests otherwise.
-- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to lightdm in Ubuntu. https://bugs.launchpad.net/bugs/2104169 Title: Useful parts of the Ubuntu delta accidentally discarded, needs restoring before Plucky's release Status in lightdm package in Ubuntu: In Progress Bug description: # Context Earlier this cycle, I synced lightdm, under the impression that the vast majority of the fixes were upstreamed: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6 This required a near-immediate followup upload: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6ubuntu1 And after some feedback, some additional configuration tweaks: https://launchpad.net/ubuntu/+source/lightdm/1.32.0-6ubuntu2 After close examination of the delta between the lightdm in 24.10 and Plucky, it seems I missed a few other elements, which are resurfacing in bugs like bug 2098411. It's time to clean this up and be more consistent with 24.10's lightdm. # Addressing Freezes If someone were to take a quick look at this diff, they might be hesitant to accept it. It might seem to break Feature Freeze. This being said, it does not. Allow me to explain why. Feature Freeze is only applicable to features as compared to the previous release. This is why source NEW packages are okay past Feature Freeze, because they don't add any features to existing packages, as compared to the previous release. In this specific case, the current state of lightdm has regressed in terms of featureset compared to Oracular. Restoring that featureset and providing a remedy for that regression, in and of itself, simply restores feature parity between the two releases. Care was taken so only the necessary parts of the Debian delta in Oracular are included. If, despite this rationale, you are still insistent on a Feature Freeze Exception, please consider this a non-conventional request. # QA and Testing Plan The following flavors are affected by this change: - Ubuntu Budgie - Ubuntu MATE - Ubuntu Unity - Ubuntu Cinnamon - Ubuntu Kylin - Xubuntu As part of the quality assurance for this change, I have personally tested all six flavors. As with any bug, I first established a baseline with 24.10, the "known good." I then tested with the current Plucky dailies, the "known bad." Finally, I tested with the newly- patched lightdm, which is, I suppose, the "newly-known good." 1. Simple smoke test: can you log in, log out, and log back in? a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 2. Guest sessions are disabled. a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin b. Known Bad: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 3. `XDG_*` is properly populated. a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin b. Known Bad: ✅ Budgie (known good), ✘ MATE, ✘ Cinnamon, ✘ Kylin c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 4. Invalid configuration files show a popup when attempting to start lightdm. a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity, ✘ Cinnamon, ✘ Kylin c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin 5. logrotate is used (or at least recognized) instead of the built-in logging backup system. a. Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin b. Known Bad: ✘ Budgie, ✘ MATE, ✘ Unity, ✘ Cinnamon, ✘ Kylin c. Newly-Known Good: ✅ Budgie, ✅ MATE, ✅ Unity, ✅ Cinnamon, ✅ Kylin This would involve finding a way to crash, which is outside the scope of this bug report, but the apport hook was also added back. Therefore, I personally certify that I have tested this upload against all five manual QA points as described, and that no obvious regressions exist from smoke tests otherwise. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/2104169/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
