I have verified the fix using util-linux 2.34-0.1ubuntu9.4 from focal- proposed:
$ qemu-img create -f qcow2 test.img 20G Formatting 'test.img', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=21474836480 lazy_refcounts=off refcount_bits=16 $ qemu-system-x86_64 -enable-kvm -m 4096 -name test -drive file=test.img,format=qcow2 -net nic,model=virtio -net user,hostfwd=tcp::7022-:22 -vga virtio -cdrom ~/downloads/ubuntu-20.04.6-desktop-amd64.iso qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2] Inside the VM: ubuntu@ubuntu:~$ sudo parted -s /dev/sda -- mklabel msdos ubuntu@ubuntu:~$ sudo parted -s /dev/sda -- mkpart primary 0% 10% mkpart primary 10% 30% ubuntu@ubuntu:~$ sudo wipefs /dev/sda DEVICE OFFSET TYPE UUID LABEL sda 0x1fe dos sda 0x1d2 atari ubuntu@ubuntu:~$ sudo vi /etc/apt/sources.list ubuntu@ubuntu:~$ sudo apt update Ign:1 cdrom://Ubuntu 20.04.6 LTS _Focal Fossa_ - Release amd64 (20230316) focal InRelease Hit:2 cdrom://Ubuntu 20.04.6 LTS _Focal Fossa_ - Release amd64 (20230316) focal Release Hit:4 http://archive.ubuntu.com/ubuntu focal InRelease Hit:5 http://archive.ubuntu.com/ubuntu focal-updates InRelease Get:6 http://security.ubuntu.com/ubuntu focal-proposed InRelease [267 kB] Hit:7 http://security.ubuntu.com/ubuntu focal-security InRelease Get:8 http://security.ubuntu.com/ubuntu focal-proposed/main amd64 Packages [259 kB] Get:9 http://security.ubuntu.com/ubuntu focal-proposed/main Translation-en [56.7 kB] Get:10 http://security.ubuntu.com/ubuntu focal-proposed/main amd64 DEP-11 Metadata [9,384 B] Get:11 http://security.ubuntu.com/ubuntu focal-proposed/main DEP-11 48x48 Icons [10.3 kB] Get:12 http://security.ubuntu.com/ubuntu focal-proposed/main DEP-11 64x64 Icons [15.7 kB] Get:13 http://security.ubuntu.com/ubuntu focal-proposed/main DEP-11 64x64@2 Icons [29 B] Get:14 http://security.ubuntu.com/ubuntu focal-proposed/main amd64 c-n-f Metadata [2,684 B] Get:15 http://security.ubuntu.com/ubuntu focal-proposed/restricted amd64 Packages [298 kB] Get:16 http://security.ubuntu.com/ubuntu focal-proposed/restricted Translation-en [43.5 kB] Get:17 http://security.ubuntu.com/ubuntu focal-proposed/restricted amd64 c-n-f Metadata [316 B] Fetched 963 kB in 2s (576 kB/s) Reading package lists... Done Building dependency tree Reading state information... Done 267 packages can be upgraded. Run 'apt list --upgradable' to see them. ubuntu@ubuntu:~$ sudo apt install libblkid1 Reading package lists... Done Building dependency tree Reading state information... Done The following packages will be upgraded: libblkid1 1 upgraded, 0 newly installed, 0 to remove and 266 not upgraded. Need to get 137 kB of archives. After this operation, 0 B of additional disk space will be used. Get:1 http://security.ubuntu.com/ubuntu focal-proposed/main amd64 libblkid1 amd64 2.34-0.1ubuntu9.4 [137 kB] Fetched 137 kB in 1s (179 kB/s) (Reading database ... 188675 files and directories currently installed.) Preparing to unpack .../libblkid1_2.34-0.1ubuntu9.4_amd64.deb ... Unpacking libblkid1:amd64 (2.34-0.1ubuntu9.4) over (2.34-0.1ubuntu9.3) ... Setting up libblkid1:amd64 (2.34-0.1ubuntu9.4) ... Processing triggers for libc-bin (2.31-0ubuntu9.9) ... ubuntu@ubuntu:~$ apt-cache policy libblkid1 libblkid1: Installed: 2.34-0.1ubuntu9.4 Candidate: 2.34-0.1ubuntu9.4 Version table: *** 2.34-0.1ubuntu9.4 500 500 http://security.ubuntu.com/ubuntu focal-proposed/main amd64 Packages 100 /var/lib/dpkg/status 2.34-0.1ubuntu9.3 500 500 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages 500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages 2.34-0.1ubuntu9 500 500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages ubuntu@ubuntu:~$ sudo wipefs /dev/sda DEVICE OFFSET TYPE UUID LABEL sda 0x1fe dos ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to util-linux in Ubuntu. https://bugs.launchpad.net/bugs/2015355 Title: Please backport patches for false atari partition detection to Ubuntu 20.04 Status in util-linux package in Ubuntu: Fix Released Status in util-linux source package in Focal: Fix Committed Bug description: [Impact] The partition detection logic in libblkid1 can falsely report the presence of an atari partition. One place where this has a practical impact is in kubernetes where mount-utils will refuse to format the device (https://github.com/kubernetes/mount- utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441). [Test Plan] * Create a new qcow2 disk image: $ qemu-img create -f qcow2 test.img 20G * Boot a focal ISO with QEMU/KVM as if installing to test.img: $ qemu-system-x86_64 -enable-kvm -m 4096 -name test -drive file=test.img,format=qcow2 -net nic,model=virtio -net user,hostfwd=tcp::1022-:22 -vga virtio -cdrom ubuntu-20.04.6-desktop- amd64.iso * Using the live environment, format the empty disk. These particular commands were given as a reproducer on the upstream bug report (https://github.com/util-linux/util-linux/issues/1116). $ parted -s /dev/sda -- mklabel msdos $ parted -s /dev/sda -- mkpart primary 0% 10% mkpart primary 10% 30% * Run wipefs on /dev/sda to list partitions. On an affected machine, an atari partition will be listed. On a fixed machine, the incorrect atari listing will be gone. $ wipefs /dev/sda DEVICE OFFSET TYPE UUID LABEL sda 0x1fe dos sda 0x1d2 atari [Where problems could occur] These patches specifically address the atari prober logic in libblkid. Therefore, if we saw regressions it would be related to detecting atari partitions with libblkid. This would potentially impact tools such as wipefs and blkid, or any other tool that uses libblkid1 for this purpose. [Original Description] There are three patches in util-linux upstream that were released in util-linux 2.37 and prevent false detection of the atari partition table with blkid and wipefs. We see this mostly on LUKS devices initialised via luksFormat reporting there is an atari partition table on the device when it is empty. This causes issues in various places, but one key example for us is in kubernetes where mount-utils will refuse to format the device (https://github.com/kubernetes/mount- utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441) RedHat backported these fixes to RHEL 8 under https://bugzilla.redhat.com/show_bug.cgi?id=2060030 and it would be helpful if Ubuntu also backported them to Ubuntu 20.04 which is still running util-linux 2.34 The request is to backport patches based on the https://github.com/util-linux/util-linux/issues/1159 upstream report. Upstream commits to cherry-pick the changes to libblkid/src/partitions/atari.c from: 2cc76d50d7a14bef8e7b07fab11b26c9e49d36a2 282ceadc3a72fc07dd0388b8880fd751490bb87f c70b4f2a5b99876d230b8f4f413c3bb3ee6647f1 # lsb_release -a Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal # blkid -V blkid from util-linux 2.34 (libblkid 2.34.0, 14-Jun-2019) # blkid -p -s TYPE -s PTTYPE -o export /dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted DEVNAME=dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted PTTYPE=atari # lsblk ... sdc crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64 `-3600a09803830474a735d4c63744c4a56 crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64 `-pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2015355/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
