After discussion with Seb, have confirmed that the language pack gets
updated strings injected from the package build, so does not need an
updated .pot file in the source tarball.
I noticed in the review that there is a change to debian/control,
dropping references to gir1.2-snapd-1. Normally we should avoid
packaging changes in SRUs. In this case, I'm unable to find any
references to snapd in the python source, so this looks safe.
There are also some translatable string differences between the SRUed
version and the version in lunar, e.g.:
- <property name="label" translatable="yes">Enter code on
ubuntu.com/pro/attach</property>
+ <property name="label" translatable="yes">Log in with Ubuntu
One</property>
and:
- <property name="label"
translatable="yes"><b>FIPS 140-2</b></property>
+ <property name="label"><b>FIPS
140-2</b></property>
This is a concern because it means these are new untranslated strings
which our translators have had no head start on being able to translate
in the devel series (which would make it a lot easier to copy the
translations back for the identical strings to the stable series).
While the window here is short enough that we might not have any new
translations anyway, I think it's improper to introduce new English-
language strings in this way, for users to be confronted with in an
otherwise-localized system.
Anyway, I'm accepting this, but I would like to see some committment to
following through with the translation team so they are aware there are
new strings to be translated in the default desktop in a stable series,
and have a chance to get updates into a language pack update for the
next point release.
** Changed in: software-properties (Ubuntu Jammy)
Status: New => Fix Committed
** Tags added: verification-needed-jammy
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to software-properties in
Ubuntu.
https://bugs.launchpad.net/bugs/2003527
Title:
Replace the Livepatch tab by an Ubuntu Pro one
Status in software-properties package in Ubuntu:
Fix Released
Status in software-properties source package in Focal:
New
Status in software-properties source package in Jammy:
Fix Committed
Bug description:
* Impact
We want desktop integration with Ubuntu Pro, that will also replace
the custom registration code we had for Livepatch which is integrated
with the new service
* Test case
- ensure that the machine isn't attached to ubuntu pro (otherwise the screen
would not be displayed) and is online
$ pro status
and `$ pro deteach` if needed
- until the service is in production to try the magic workflow, edit
/etc/ubuntu-advantage/uaclient.conf to set
contract_url: https://contracts.staging.canonical.com
then 'ua refresh config')
and use the non staging for token registration
- $ software-properties-gtk
-> the list of tabs should include an 'Ubuntu Pro' one and no 'Livepatch'
The Ubuntu Pro tab should state 'This machine is not covered by an
Ubuntu Pro subscription', display a 'Enable Ubuntu Pro' button and
have other controls inactive
- click 'Enable Ubuntu Pro'
-> A dialog 'Enable Ubuntu Pro' opens
-> the first option 'Enter code on ubuntu.com/pro/attach' is selected
-> a pincode is displayed under the option
- go to http//ubuntu.com/pro/attach and enter the pincode
-> after some seconds the software-properties UI should update and display a
green mark and 'Valid token' label on the right of the pincode
- click 'Confirm'
-> you should get an authentification prompt
- enter your password
-> a spinner starts animating instead of the 'Valid token' label
-> once the attachment job is done the dialog is autoclosed
-> the UI should now state 'Ubuntu Pro support is enabled', under Security
'ESM Infra', 'ESM Apps' and 'Kernel Livepatch' should be displayed an enabled
(or without 'ESM Apps' if you don't have the current ubuntu-advantage-tools)
- check that the '$ pro status' output matches the UI one
- try enabling/disable options
-> verify that the 'pro status' change accordingly
- Click 'Disable Ubuntu Pro'
-> you get asked for confirmation and password
-> confirm that the UI is back to the original state and that 'pro status'
confirm the system isn't attached to Ubuntu Pro anymore
- Go through the testcase again but selecting the 'Or add token
manually' option, the steps should be similar
* Regression Potential
There could be problems in the UI
The new service could be not working as expected
Strings are new and currently have no translations
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/2003527/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
