(c)inaddy@iproute2verification:~/work/sources/ubuntu/chrony/test/simulation/clknetsim$
git bisect bad
537cb7161de9ad372437ab0fcbff76e54a3cd97a is the first bad commit
commit 537cb7161de9ad372437ab0fcbff76e54a3cd97a
Author: Miroslav Lichvar <[email protected]>
Date: Tue Jun 11 17:05:22 2019 +0200
add message type
:100644 100644 2898b26a7b1311647b4419da79000e69b6d89b39
5b6d8917e1dd4667fe124b22a907e42286cb86f4 M client.c
:100644 100644 20f052d7583d6051e779fd7318f47a3867595993
5cab1f4e86f95719814657da69a93089d029025e M client_fuzz.c
:100644 100644 7b2fcbe0c5d39193946afebbd778a506c3452cb9
eeff3aba6b4bc46dc0ef516257a8ff130549a827 M network.cc
:100644 100644 427036573b6da7227c5d7fa169a3d81627330d9c
b5fe35b408f2a635455548d2b7dfd0ec7ec6da90 M network.h
:100644 100644 be9d6fa5177c49acd3906643fc010576a5d5369d
cf94b9e42bdb6a1b33b84afe8b5e19a9a5d00806 M node.cc
:100644 100644 36e4e328ce10b062166c101a1d4c74244af558ab
da78179483f88c84314c85af8dbfd9843332a33d M protocol.h
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to iproute2 in Ubuntu.
https://bugs.launchpad.net/bugs/1831775
Title:
ss seems broken when using multiple filters in the same cmdline
Status in iproute2 package in Ubuntu:
Fix Released
Status in iproute2 source package in Cosmic:
Won't Fix
Status in iproute2 source package in Disco:
Fix Committed
Status in iproute2 source package in Eoan:
Fix Released
Bug description:
[Impact]
* ss won't be able to run commands with single filters inside
parentheses, like: "( sport == :X )", for example.
* A workaround is to remove "( )" from single filters, since it looks
the issue does not affect 2 filters being put together in the same
parentheses, like: " ( X and Y ) and Y " instead of ( X and Y ) and (
Y )".
* CTDB is unable to use ss filter to obtain nodes public IP addresses
in order to fail over services (LP: #722201).
[Test Case]
* Having an Ubuntu Cosmic, Disco or Eoan, try to execute the
following command:
$ ss -tn state established "( src [172.16.17.2] || src [172.16.17.3]
)" "( sport == :2049 )"
Independent of the IPs or ports being used. Copying and pasting the
command should be enough for you to know if you are affected.
Bad Result:
ss: bison bellows (while parsing filter): "syntax error!" Sorry.
Usage: ss [ OPTIONS ]
ss [ OPTIONS ] [ FILTER ]
-h, --help this message
...
Expected Result:
Recv-Q Send-Q Local Address:Port
Peer Address:Port
...
* test case was discovered during CTDB scripts execution
[Regression Potential]
* biggest risk would be to affect ss interpreter (worst case scenario).
* the proposed patch is based in upstream fix and was tested against the
same issue reported as the reproducer (above) and some other generic ss
commands.
* any problem here is unlikely to change iproute2 most important command
interpreter, "ip", since the patch is applied against ss code.
[Other Info]
ORIGINAL DESCRIPTION:
Investigating an issue for CTDB (LP: #722201), after suggesting a fix
on ss syntax to CTDB upstream project, we discovered that "ss" seems
to be broken in Ubuntu since Ubuntu Cosmic:
----
# Debian Sid
inaddy@workstation:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
Recv-Q Send-Q Local Address:Port
Peer Address:Port
# Ubuntu Ubuntu 16.04 LTS (Xenial Xerus)
(c)inaddy@xenial:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
Recv-Q Send-Q Local Address:Port
Peer Address:Port
# Ubuntu 18.04 LTS (Bionic Beaver)
(c)inaddy@bionic:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
Recv-Q Send-Q Local Address:Port
Peer Address:Port
# Ubuntu 18.10 (Cosmic Cuttlefish)
(c)inaddy@cosmic:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
ss: bison bellows (while parsing filter): "syntax error!" Sorry.
Usage: ss [ OPTIONS ]
ss [ OPTIONS ] [ FILTER ]
-h, --help this message
# Ubuntu 19.04 (Disco Dingo)
(c)inaddy@disco:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
ss: bison bellows (while parsing filter): "syntax error!" Sorry.
Usage: ss [ OPTIONS ]
ss [ OPTIONS ] [ FILTER ]
# Ubuntu 19.10 (Eoan Ermine)
(c)inaddy@eoan:~$ ss -tn state established "( src [172.16.17.2] || src
[172.16.17.3] )" "( sport == :2049 )"
ss: bison bellows (while parsing filter): "syntax error!" Sorry.
Usage: ss [ OPTIONS ]
ss [ OPTIONS ] [ FILTER ]
----
I have generated a pkg using upstream iproute2 source code and it does
not suffer the issue. I have generated a package using Ubuntu cosmic
source package, without debian/patches/*, and verified the issue still
persists (not being introduced by any of our packages, and being
present if vanilla upstream version used in Cosmic).
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1831775/+subscriptions
--
Mailing list: https://launchpad.net/~touch-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~touch-packages
More help : https://help.launchpad.net/ListHelp
