On Tue, Jan 9, 2018 at 12:38 PM, Iain Lane <i...@orangesquash.org.uk> wrote:
> Andy asked me to have a look, so here's my initial feedback. > > General > ======= > > I'm not sure if these changes should be backported to Artful too, to > maintain the upgrade path for users transitioning off Xenial. Could you > please ask the SRU team? > At least for our usecase there is no need to backport this to Artful. Who should I ask? > > Otherwise, the changes are risky but I think they should be in principle > okay. > > The test cases and regression potential in the description here could do > with fleshing out a bit - could you do that please? For example, > snapcraft depends on pymacaroons - probably want to make sure that keeps > working. And it is supposed to be compatible, but that doesn't mean > there is no bug in the newer version - it is a regression potential IMO. > I tested snapcraft-login as in above question. > > httmock > ======= > > Since this is completely new and a no-change backport, I think it's > okay. Uploaded. > > protobuf > ======== > > I'm a bit worried about bugs coming from the use of 2to3 which is best > used as a starting point for a manual port, not for an automatic > conversion - how about taking the upstream patches instead? > > https://github.com/google/protobuf/commit/f336d4b7a5c1d369ed508e513d482c > 885705e939 > > https://github.com/google/protobuf/commit/fe7d9379df3ce7c951bc0652a45141 > 3cff02382a > > https://github.com/google/protobuf/commit/47ee4d37c17db8e97fe5b15cf918ab > 56ff93bb18 > > I tried the testsuite with this and it works after resolving some minor > conflicts. > I'll take a look into it. > > pymacaroons > =========== > > Seems okay if it's compatible - can you check with Colin please? I'm > happy to handle the actual upload. > > py-macaroon-bakery > ================== > > I'm not qualified to review this - maybe also check with Colin as the > maintainer? The patch says it's editing a generated file - is that > right? > It's editing the protobuf generated file. It seems like these changes are wire-compatible with the livepatch servers". > > ** Changed in: httmock (Ubuntu) > Status: New => In Progress > > ** Changed in: httmock (Ubuntu) > Assignee: (unassigned) => Andrea Azzarone (azzar1) > > ** Also affects: protobuf (Ubuntu Xenial) > Importance: Undecided > Status: New > > ** Also affects: python-nacl (Ubuntu Xenial) > Importance: Undecided > Status: New > > ** Also affects: pymacaroons (Ubuntu Xenial) > Importance: Undecided > Status: New > > ** Also affects: httmock (Ubuntu Xenial) > Importance: Undecided > Status: New > > ** Changed in: httmock (Ubuntu) > Status: In Progress => Fix Released > > ** Changed in: httmock (Ubuntu Xenial) > Status: New => In Progress > > ** Changed in: httmock (Ubuntu Xenial) > Assignee: (unassigned) => Andrea Azzarone (azzar1) > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1735160 > > Title: > [SRU] Please backport python3-macaroonbakery 0.0.6-1 [universe] from > bionic > > Status in httmock package in Ubuntu: > Fix Released > Status in protobuf package in Ubuntu: > New > Status in pymacaroons package in Ubuntu: > New > Status in python-nacl package in Ubuntu: > New > Status in httmock source package in Xenial: > In Progress > Status in protobuf source package in Xenial: > New > Status in pymacaroons source package in Xenial: > New > Status in python-nacl source package in Xenial: > New > > Bug description: > [Impact] > As part of allowing Ubuntu users to enable canonical-livepatch from > software-properties GUI (https://wiki.ubuntu.com/SoftwareUpdates#Update_ > settings) we need to backport python3-macaroonbakery 0.0.6-1 [universe] > from bionic. This will requires quite few changes: > > - backport httmock 1.2.6-1 [universe] from bionic - no httmock in xenial > - backport pymacaroons 0.12.0-1 [universe] from bionic - xenial has > 0.9.2-0ubuntu1 > - SRU some changes in google-apputils-python - > https://bugs.launchpad.net/ubuntu/+source/google- > apputils-python/+bug/1735162 > - add python3-protobuf to python-protobuf 2.6.1-1.3 - Right now the > python3 package is not built. > > [Test case] > - for python3-protobuf: $ python3 -c "import google.protobuf" > - for python3-macaroonbakery: make sure all the tests pass > > [Regression Potential] > - httmock, none has it's not in xenial > - python3-protobuf, none has the python2 code was not edited > TBC > - pymacaroons, none has 0.12 is backward compatible with 0.9.2 > - python3-protobuf, none has it's not in xenial. > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+source/httmock/+bug/ > 1735160/+subscriptions > > Launchpad-Notification-Type: bug > Launchpad-Bug: distribution=ubuntu; sourcepackage=httmock; > component=universe; status=Fix Released; importance=Undecided; assignee= > andrea.azzar...@canonical.com; > Launchpad-Bug: distribution=ubuntu; sourcepackage=protobuf; > component=main; status=New; importance=Undecided; assignee=None; > Launchpad-Bug: distribution=ubuntu; sourcepackage=pymacaroons; > component=universe; status=New; importance=Undecided; assignee=None; > Launchpad-Bug: distribution=ubuntu; sourcepackage=python-nacl; > component=universe; status=New; importance=Undecided; assignee=None; > Launchpad-Bug: distribution=ubuntu; distroseries=xenial; > sourcepackage=httmock; component=None; status=In Progress; > importance=Undecided; assignee=andrea.azzar...@canonical.com; > Launchpad-Bug: distribution=ubuntu; distroseries=xenial; > sourcepackage=protobuf; component=main; status=New; importance=Undecided; > assignee=None; > Launchpad-Bug: distribution=ubuntu; distroseries=xenial; > sourcepackage=pymacaroons; component=universe; status=New; > importance=Undecided; assignee=None; > Launchpad-Bug: distribution=ubuntu; distroseries=xenial; > sourcepackage=python-nacl; component=universe; status=New; > importance=Undecided; assignee=None; > Launchpad-Bug-Tags: patch > Launchpad-Bug-Information-Type: Public > Launchpad-Bug-Private: no > Launchpad-Bug-Security-Vulnerability: no > Launchpad-Bug-Commenters: azzar1 crichton laney tsimonq2 > Launchpad-Bug-Reporter: Andrea Azzarone (azzar1) > Launchpad-Bug-Modifier: Iain Lane (laney) > Launchpad-Message-Rationale: Subscriber > Launchpad-Message-For: azzar1 > -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to protobuf in Ubuntu. https://bugs.launchpad.net/bugs/1735160 Title: [SRU] Please backport python3-macaroonbakery 0.0.6-1 [universe] from bionic Status in httmock package in Ubuntu: Fix Released Status in protobuf package in Ubuntu: New Status in pymacaroons package in Ubuntu: New Status in python-nacl package in Ubuntu: New Status in httmock source package in Xenial: In Progress Status in protobuf source package in Xenial: New Status in pymacaroons source package in Xenial: New Status in python-nacl source package in Xenial: New Bug description: [Impact] As part of allowing Ubuntu users to enable canonical-livepatch from software-properties GUI (https://wiki.ubuntu.com/SoftwareUpdates#Update_settings) we need to backport python3-macaroonbakery 0.0.6-1 [universe] from bionic. This will requires quite few changes: - backport httmock 1.2.6-1 [universe] from bionic - no httmock in xenial - backport pymacaroons 0.12.0-1 [universe] from bionic - xenial has 0.9.2-0ubuntu1 - SRU some changes in google-apputils-python - https://bugs.launchpad.net/ubuntu/+source/google-apputils-python/+bug/1735162 - add python3-protobuf to python-protobuf 2.6.1-1.3 - Right now the python3 package is not built. [Test case] - for python3-protobuf: $ python3 -c "import google.protobuf" - for python3-macaroonbakery: make sure all the tests pass [Regression Potential] - httmock, none has it's not in xenial - python3-protobuf, none has the python2 code was not edited TBC - pymacaroons, none has 0.12 is backward compatible with 0.9.2 - python3-protobuf, none has it's not in xenial. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/httmock/+bug/1735160/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
