Hi,
I again come by cleaning up dormant bugs which just means to me that it isn't 
important enough for anyone to be able to allocate time for it.
While the suggestion you made is absolutely correct it just wasn't important to 
many users it seems and also of low severity just dropping the ExecStartPre 
test on the floor by using the wrong conf.

I really think it is not worth a delta to Debian to be carried in Ubuntu
(due to low severity), as I said before Debian is just as affected - so
reporting it there would benefit Debian as well and eventually be picked
up by Ubuntu as well.

Furthermore the config dir is configurable in /etc/default/dnsmasq so maybe the 
test should follow this config as well.
That would need EnvironmentFile=-/etc/default/dnsmasq as well as some logic to 
do this conditionally if set. As far as I can see the latter can't be done in 
systemd according to its current doc (to set the -7 CONF_DIR only if set).

But it certainly could be done as:
1. drop the ExecStartPre as it tests the wrong thing
2a. implement it in the systemd-exec section in /etc/init.d/dnsmasq (there all 
vars are set up anyway)
2b. if you want to leverage StartPre then you'd need a systemd-exec-check 
section with just the same as 2a

I'd really want to encourage you to report just that to Debian.
If you are unable or unwilling please let me know, but in general it is better 
if the reporters do so.


** Tags added: need-debian-report

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to dnsmasq in Ubuntu.
https://bugs.launchpad.net/bugs/1639452

Title:
  systemd ExecStartPre test config

Status in dnsmasq package in Ubuntu:
  Triaged

Bug description:
  The standard configuration file of dnsmasq is complete commented out.
  The real configuration is saved in /etc/dnsmasq.d, so the test of
  systemd is a fake.

  In the Service Section of /lib/systemd/system/dnsmasq.service the
  ExecStartPre directive should be set to "/usr/sbin/dnsmasq --conf-
  dir=/etc/dnsmasq.d --test"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dnsmasq/+bug/1639452/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to