@Simon, couple of small things: * you should use 8.0-0ubuntu3.1 as the version instead of 8.0-0ubuntu4 * the changelog has a date of 'Tue, 17 May 2016 17:59:58 +0200' which is quite old, yet the diff was only recently uploaded. You can use 'dch -r' to update the date
More importantly: * the patch introduces compiler warnings. These should be cleaned up: +modules/module-snappy-policy.c: In function ‘connect_record_hook’: +modules/module-snappy-policy.c:57:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] + char *label = NULL; + ^ +modules/module-snappy-policy.c:65:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] + pa_hook_result_t decision = PA_HOOK_OK; + ^ * configure shows: + Enable Snappy support: no + Enable Apparmor: yes Can you comment on why snappy support was added to configure in this patch if you aren't going to use it? It seems that snappy support is compiled though, cause I see '-DHAVE_SNAPPY=1' in the build logs and see usr/lib/pulse-8.0/modules/module-snappy-policy.so is now shipped. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to pulseaudio in Ubuntu. https://bugs.launchpad.net/bugs/1583057 Title: Deny audio recording for all snap applications Status in pulseaudio package in Ubuntu: Fix Released Status in pulseaudio source package in Xenial: In Progress Status in pulseaudio source package in Yakkety: Fix Released Bug description: Until we have a proper trust-store implementation with snappy and on the desktop/ubuntu core we want pulseaudio to simply deny any audio recording request coming from an app shipped as part of a snap. The implementation adds a module-snappy-policy module to pulseaudio which adds a hook for audio recording requests and checks on connection if the apparmor security label of the connecting peer starts with "snap." which will identify it as a snap application. Pulseaudio with the patch is available as part of the landing request at https://requests.ci-train.ubuntu.com/#/ticket/1428 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1583057/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
