The problem we have is we deliberately decided not to do any validation
on the scopes API side and leave it up to the unity (even the shell
plugin doesn't care much about what's inside the preview widgets).

The downside is in many cases scope author is clueless if widget doesn't
show up or look as expected.

On the upside, support for new widgets can be added to the shell or
existing widgets can be enhanced to support new attributes without
affecting the lower layers.

Now, the problem of not having a clue as a scope author if something
goes wrong is and important issue, so perhaps we should look for a
middle ground. How about adding a simple validation and only output cerr
warnings if we see something we don't know (and never throw, unless we
find cases where we really know thw widget is totally broken)?

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unity-scopes-api in
Ubuntu.
https://bugs.launchpad.net/bugs/1381891

Title:
  Setting invalid widget attribute does not raise exception

Status in unity-scopes-api package in Ubuntu:
  New

Bug description:
  Suppose I do:

  PreviewWidget desc("summary_col", "text");
  desc.add_attribute_value("test", Variant("This is the text for the widget"));

  Did you spot the error? The attribute being set is "test", but it
  should be "text". There is no indication that I'm doing something
  impossible, and I'm left scratching my head why nothing renders.

  It might be better to raise InvalidArgumentException here?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unity-scopes-api/+bug/1381891/+subscriptions

-- 
Mailing list: https://launchpad.net/~touch-packages
Post to     : touch-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~touch-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to