Background:

If a commit comment contains a revision number that matches the 
tsvn:logrevregex regex, the revision number will be turned into a hyperlink 
in the log window. Clicking on that hyperlink will either:
1) Scroll to that revision if it is already in the list of revisions in the 
log window
2) Inject that revision into the list of revisions in the existing log 
window (done if the revision exists in the log cache)
3) Open a new log window of the repository root, starting at that revision 
number (done if the revision is *not *in the log cache)

The bug:

When the revision is injected into the existing log window, it doesn't show 
any modified file paths, so you can't even see what branch that revision 
made changes in.

Besides this bug, it seem unintuitive to inject an arbitrary revision into 
the existing log window. We often mention revision numbers when merging 
revisions from other branches, and it's confusing to have a revision from 
branch B injected when you are viewing a log of branch A.

Rather than fixing the bug, my suggestion is to remove the try-catch block 
from CLogDlg::OnEnLinkMsgview() so it always opens the revision in a new 
window if it isn't already included in the existing list of revisions. 
Besides bypassing the bug, this will make the behavior consistent whether 
the revision is cached or not.

Thanks!

Dave Lawrence

-- 
You received this message because you are subscribed to the Google Groups 
"TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tortoisesvn+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tortoisesvn/412cc24f-4d2d-4d97-9e6d-e7ce24749824n%40googlegroups.com.

Reply via email to