DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36541>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36541 ------- Additional Comments From [EMAIL PROTECTED] 2005-09-14 10:29 ------- Ok, so completely innocently here (despite what people may happen to think - I'm *still* incensed by reading the history on this bug, and still feel well and truly PO'd...) Why does the following not represent an issue in DeltaSession 1.35? http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/ catalina/cluster/session/DeltaSession.java?rev=1.35&view=markup Access to attributes.put() remains unsynchronized; synchronizing the remainder, especially when other methods are synchronized, strikes me as an oversight - it should cause the exact same problem (albeit less often, because reads are being serialized) as a put can still cause the hashmap to resize, and therefore still hit the problem; those puts are also allowed during retrieval of attributes.keyset() and other long-running actions as a result of this. removeAttributeInternal() also fails to synchronize the removal of the attribute from the map, and thus also creates the issue; attribute removal and insert can both cause a right-timed reader to fail. So it's not just limited to StandardSession, which... http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ session/StandardSession.java?rev=1.60&view=markup also fails to synchronize its session data in the current 5.0.11 branch - although it, too, does half the job by performing unsynchronized reads, synchronizing writes, failing to synchronize keyset retrieval, etc. So how is this not a 5.5 bug? StandardSession will definitely exhibit the behavior a lot more often, but the bug is still fundamentally *there* on both. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
