Remy Maucherat wrote:
Mladen Turk wrote:

[EMAIL PROTECTED] wrote:

jfclere     2005/04/16 03:31:34

Modified: jni/java/org/apache/tomcat/jni Socket.java
jni/native/src network.c
Log:
Throw an exception when bind() failed.



Why did you do that? I mean there is no need to throw an exception if we can get a direct APR status code. The trow is used *only* for functions that return status and fill a single pointer.

We are not trying to be Java compatible, but as close to follow the
APR api (as is possible).


Yes, please don't start adding exception throwing everywhere.

I'm only -0 for this particular commit, since there are far worse places to throw something.

Ok I am now convinced that testing apr-status is better than throwing exception...


Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to