billbarker 2005/03/24 19:53:25
Modified: util/java/org/apache/tomcat/util/http MimeHeaders.java
Log:
Make setValue guarantee that the header is unique (that's how it's being used anyway).
Fix for Bug #34113
- MessageBytes value=getValue(name);
- if( value == null ) {
- MimeHeaderField mh = createHeader();
- mh.getName().setString(name);
- value=mh.getValue();
- }
- return value;
+ for ( int i = 0; i < count; i++ ) {
+ if(headers[i].getName().equalsIgnoreCase(name)) {
+ for ( int j=i+1; j < count; j++ ) {
+ if(headers[j].getName().equalsIgnoreCase(name)) {
+ removeHeader(j--);
+ }
+ }
+ return headers[i].getValue();
+ }
+ }
+ MimeHeaderField mh = createHeader();
+ mh.getName().setString(name);
+ return mh.getValue();
This should be more efficient as I don't like what removeHeader does. Since it only happens when actually having a multi valued header, it is not that critical, however.
Rémy
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
