DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=33219>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=33219 Summary: Slight code improvement Product: Tomcat 5 Version: Nightly Build Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P5 Component: Jasper AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] I found what I would classify as a small "broken window" (really more of a nick than a break) while debugging another problem. Below is a patch for org/apache/jasper/servlet/JspServletWrapper.java to remove unnecessary conditional statements. The change will not really have much, if any, affect on performance, although there will be fewer bytecodes, less (and simpler) source code. --- JspServletWrapper.java.orig 2005-01-24 09:40:38.000000000 -0500 +++ JspServletWrapper.java 2005-01-24 09:42:19.000000000 -0500 @@ -196,9 +196,7 @@ } if (options.getDevelopment() || firstTime ) { synchronized (this) { - if (firstTime) { - firstTime = false; - } + firstTime = false; ctxt.compile(); } } else { @@ -289,9 +287,7 @@ */ if (options.getDevelopment() || firstTime ) { synchronized (this) { - if (firstTime) { - firstTime = false; - } + firstTime = false; // The following sets reload to true, if necessary ctxt.compile(); } -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
