Hi, Thanks for noting and resolving the bug. I'm hesitant to put out a new 5.5.3 build though, because that will create confusion among those who've already downloaded it. But we do have other options: - Just issue a hotfix with StandardWrapper.class, tell people to put it in server/lib. We've done this before with other single-class fixes, so there's precedent. - Issue a new 5.5.3.1 (now possible with the new versioning scheme) release. - Leave this be, keep 5.5.3 at alpha, and have this fix go only into 5.5.4.
What do people think? Yoav Shapira Millennium Research Informatics >-----Original Message----- >From: Amy Roh [mailto:[EMAIL PROTECTED] >Sent: Wednesday, October 06, 2004 5:33 PM >To: Tomcat Developers List >Subject: Re: TCKs for 5.5.3 and 5.0.29 > >Thanks Jan for the update. > >I have confirmed that all JSP TCK tests pass with the latest >StandardWrapper.java. I have retagged the file so the 5.5.3 release has >the >fix. > >Thanks, >Amy > > >> Hi Amy, >> >> Amy Roh wrote: >>> I ran the Servlet/JSP TCKs. They both passed on the 5.0.29 release. >>> >>> The Servlet TCK passed on the 5.5.3 release but the following 2 JSP TCK >>> tests failed out of 615 tests. >>> Test case throws exception: [BaseUrlClient] null failed! Check output >for >>> cause of failure. >>> a.. >>> >com/sun/ts/tests/jsp/spec/core_syntax/implicitobjects/URLClient.java#ch eckC >onfigTest >>> : URLClient_checkConfigTest >>> b.. >>> >com/sun/ts/tests/jsp/spec/tagfiles/implicitobjects/URLClient.java#check Conf >igTest >>> : URLClient_checkConfigTest >> >> I committed a fix for these 2 failures yesterday (in >> StandardWrapper.java): >> >> revision 1.49 >> date: 2004/10/06 00:54:46; author: luehe; state: Exp; lines: +1 -1 >> Undid previous change, as in the case where a servlet has a jsp-file >> and also declares some init params, as in: >> >> <servlet> >> <servlet-name>xxx</servlet-name> >> <jsp-file>/xxx.jsp</jsp-file> >> <init-param> >> <param-name>name1</param-name> >> <param-value>value1</param-value> >> </init-param> >> </servlet> >> >> it needs its *own* JspServlet instance that it can initialize with its >> own params. Sharing of JspServlet instance is not possible in this >> case. >> >> Will have to come up with a better solution against loss of monitoring >> info (the JspServlet that handles the above jsp-file currently is not >> registered with JMX). >> >> I think we need to retag this file with 5.5.3. >> >> >> Jan >> >> >>> Thanks, >>> Amy >>> >>> ----- Original Message ----- From: "Shapira, Yoav" ><[EMAIL PROTECTED]> >>> To: "Tomcat Developers List" <[EMAIL PROTECTED]> >>> Sent: Wednesday, October 06, 2004 6:28 AM >>> Subject: TCKs for 5.5.3 and 5.0.29 >>> >>> >>> >>> Hi, >>> Sun folks, or anyone with access to the Servlet and JSP TCKs: can you >>> please run them against the 5.5.3 and 5.0.29 releases when you get a >>> chance, and post your results here? Thanks in advance ;) >>> >>> Both 5.0.29 and 5.5.3 pass all our internal tests without exception. >>> >>> Yoav Shapira >>> Millennium Research Informatics >>> >>> >>> >>> >>> >>> This e-mail, including any attachments, is a confidential business >>> communication, and may contain information that is confidential, >>> proprietary and/or privileged. This e-mail is intended only for the >>> individual(s) to whom it is addressed, and may not be saved, copied, >>> printed, disclosed or used by anyone else. If you are not the(an) >>> intended recipient, please immediately delete this e-mail from your >>> computer system and notify the sender. Thank you. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]