----- Original Message -----
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Thursday, October 14, 2004 5:00 PM
Subject: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core
ApplicationHttpResponse.java


> luehe       2004/10/14 17:00:35
>
>   Modified:    catalina/src/share/org/apache/catalina/core
>                         ApplicationHttpResponse.java
>   Log:
>   Expose any errors on an included resource.
>
>   For example, a JSP with this include action:
>     <jsp:include page="nonexistent">
>   or
>     <jsp:include page="nonexistent.jsp">
>   where nonexistent[.jsp] does not exist, currently returns silently,
hiding the
>   fact that the resource to be included does not exist.
>
>   This patch returns a 404 with the name of the nonexistent resource.
>
>   Yes, SRV.8.3 ("The Include Method") mentions that
>
>     "it [the target servlet] cannot set headers or call any method that
>     affects the headers of the response. Any attempt to do so must be
>     ignored."
>
>   but i don't think it is referring to the error case.

Actually, it has always been my impression that this *is* referring to the
error case.  I think that somebody should get a clarification before making
a change this drastic.  (By the way, this doesn't do anything since the
Response is still too smart to allow an included resource to call
sendError.)

In any case, it doesn't seem to be that useful, since in the case of
<jsp:include page="nonexistent.jsp" flush="true" > it is way too late to do
a meaningful sendError.

>
>   Let me know if you see any problems.
>


This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to