Peter Rossbach wrote:

Hey,

we have many duplicate attributes at connector and protocolhandler classes-
I have spent a lot of time to fix that at my new server.xml/context.xml storage
module.
Current design based on factory model with external description file to handle those issues.
Very strange, but my only chance to implement the handler, without break the current codebase.


We must refactor the Connector/Protocoll class to make a clear cut,
between old and correct attributes. We drop maxProcessors and minProcessors attributes as example.

Yes, we need to remove any useless field. More generally, the idea in this branch is to remove anything useless.


My current questions are:
Why we handle all connectors attributes as real class attributes
and dymamic properties?
Can we drop the attribute translation between Connector and ProtocolHandler?

No, we likely can't, because accessing them would become slow, and some are used during request processing (so they need to remain fields on the Connector class).


Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to