cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector Response.java Request.java

[remm]

remm        2004/09/16 08:28:30

  Modified:    catalina/src/share/org/apache/catalina/connector
                        Response.java Request.java
  Log:
  - getRequest/getResponse should return the most relevant interface, to avoid casts.
  
  Revision  Changes    Path
  1.9       +2 -3      
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Response.java
  
  Index: Response.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Response.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Response.java     29 Aug 2004 16:46:09 -0000      1.8
  +++ Response.java     16 Sep 2004 15:28:29 -0000      1.9
  @@ -34,7 +34,6 @@
   import java.util.Vector;
   
   import javax.servlet.ServletOutputStream;
  -import javax.servlet.ServletResponse;
   import javax.servlet.http.Cookie;
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
  @@ -381,7 +380,7 @@
        * Return the <code>ServletResponse</code> for which this object
        * is the facade.
        */
  -    public ServletResponse getResponse() {
  +    public HttpServletResponse getResponse() {
           if (facade == null) {
               facade = new ResponseFacade(this);
           }
  
  
  
  1.13      +2 -3      
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java
  
  Index: Request.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/Request.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- Request.java      9 Aug 2004 22:55:00 -0000       1.12
  +++ Request.java      16 Sep 2004 15:28:30 -0000      1.13
  @@ -38,7 +38,6 @@
   import javax.servlet.RequestDispatcher;
   import javax.servlet.ServletContext;
   import javax.servlet.ServletInputStream;
  -import javax.servlet.ServletRequest;
   import javax.servlet.ServletRequestAttributeEvent;
   import javax.servlet.ServletRequestAttributeListener;
   import javax.servlet.http.Cookie;
  @@ -558,7 +557,7 @@
        * Return the <code>ServletRequest</code> for which this object
        * is the facade.  This method must be implemented by a subclass.
        */
  -    public ServletRequest getRequest() {
  +    public HttpServletRequest getRequest() {
           if (facade == null) {
               facade = new RequestFacade(this);
           } 
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]