----- Original Message -----
From: "Peter Rossbach" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Monday, August 02, 2004 11:24 PM
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core
StandardHost.java
> Hello Bill,
>
> I see the change, but I missing the attribute managedResource at the
> Realms.mbeans-descriptors.xml.
>
I just assumed that you'd be doing this one soon enough (since it's on your
wish-list ;-).
Since this feature has obviously never worked (the old code was so wrong in
so many ways :), I figured that it could not work for a little while
longer. It's just something that I noticed while seeing how to get the
admin webapp to play nice with the Deployer.
> Thanx
> Peter
>
> [EMAIL PROTECTED] schrieb:
>
> >billbarker 2004/08/02 20:01:03
> >
> > Modified: catalina/src/share/org/apache/catalina/core
> > StandardHost.java
> > Log:
> > Small changes for JMX deployment
> >
> > -- Create a Deployer for this Host.
> > -- Fix the "discover orphaned Realm" logic. This still requires that
the Realm MBean exposes the "managedResource" attribute, but it was so
broken before that nobody could have been using it.
> >
> > Revision Changes Path
> > 1.33 +10 -7
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/Standard
Host.java
> >
> > Index: StandardHost.java
> > ===================================================================
> > RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/cor
e/StandardHost.java,v
> > retrieving revision 1.32
> > retrieving revision 1.33
> > diff -u -r1.32 -r1.33
> > --- StandardHost.java 28 Jul 2004 18:02:15 -0000 1.32
> > +++ StandardHost.java 3 Aug 2004 03:01:03 -0000 1.33
> > @@ -29,9 +29,11 @@
> > import org.apache.catalina.Context;
> > import org.apache.catalina.DefaultContext;
> > import org.apache.catalina.Host;
> > +import org.apache.catalina.Realm;
> > import org.apache.catalina.LifecycleException;
> > import org.apache.catalina.Valve;
> > import org.apache.catalina.valves.ValveBase;
> > +import org.apache.catalina.startup.HostConfig;
> > import org.apache.commons.modeler.Registry;
> >
> >
> > @@ -736,12 +738,11 @@
> > if( realm == null ) {
> > ObjectName realmName=null;
> > try {
> > - realmName=new ObjectName( domain + ":type=Host,host="
+ getName());
> > + realmName=new ObjectName( domain + ":type=Realm,host="
+ getName());
> > if( mserver.isRegistered(realmName ) ) {
> > - mserver.invoke(realmName, "setContext",
> > - new Object[] {this},
> > - new String[] {
"org.apache.catalina.Container" }
> > - );
> > + Realm nrealm =
(Realm)mserver.getAttribute(realmName,
> > +
"managedResource");
> > + setRealm(nrealm);
> > }
> > } catch( Throwable t ) {
> > log.debug("No realm for this host " + realmName);
> > @@ -830,7 +831,9 @@
> > // Register with the Engine
> > ObjectName serviceName=new ObjectName(domain +
> > ":type=Engine");
> > -
> > +
> > + HostConfig deployer = new HostConfig();
> > + addLifecycleListener(deployer);
> > if( mserver.isRegistered( serviceName )) {
> > log.debug("Registering with the Engine");
> > mserver.invoke( serviceName, "addChild",
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: [EMAIL PROTECTED]
> >For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or
distribute this message or any attachment. If you received this communication in
error, please notify us immediately by e-mail and then delete all copies of this
message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through the
Internet is not secure. Do not send confidential or sensitive information, such as
social security numbers, account numbers, personal identification numbers and
passwords, to us via ordinary (unencrypted) e-mail.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
