DO NOT REPLY [Bug 28875] - Multi-byte characters in default error page aren't printed out correctly.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28875>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28875

Multi-byte characters in default error page aren't printed out correctly.





------- Additional Comments From [EMAIL PROTECTED]  2004-05-10 19:38 -------
Kan,

I thought revision 1.11 of CoyoteResponse.java already fixed this issue.

CVS log:

revision 1.11
date: 2004/01/20 19:39:00;  author: luehe;  state: Exp;  lines: +8 -5
Fix for Bugtraq 4655010: Method sendError() of class HttpServletResponse
                         does not send multi byte data

Use response encoding when generating error report, so that the following
code works as expected:

      response.setCharacterEncoding(<charset>);
      response.sendError(<errorCode>, <message>);


Here are the diffs for that revision:

Index: CoyoteResponse.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteResponse.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- CoyoteResponse.java 15 Oct 2003 18:47:49 -0000      1.10
+++ CoyoteResponse.java 20 Jan 2004 19:39:00 -0000      1.11
@@ -1,7 +1,7 @@
 /*
- * $Header:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteResponse.java,v
1.10 2003/10/15 18:47:49 jfarcand Exp $
- * $Revision: 1.10 $
- * $Date: 2003/10/15 18:47:49 $
+ * $Header:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteResponse.java,v
1.11 2004/01/20 19:39:00 luehe Exp $
+ * $Revision: 1.11 $
+ * $Date: 2004/01/20 19:39:00 $
  *
  * ====================================================================
  *
@@ -107,7 +107,7 @@
  *
  * @author Remy Maucherat
  * @author Craig R. McClanahan
- * @version $Revision: 1.10 $ $Date: 2003/10/15 18:47:49 $
+ * @version $Revision: 1.11 $ $Date: 2004/01/20 19:39:00 $
  */
 
 public class CoyoteResponse
@@ -529,9 +529,12 @@
      * unexpected exception thrown during the servlet processing
      * (and only in that case), null will be returned if the response stream
      * has already been used.
+     *
+     * @exception IOException if an input/output error occurs
      */
-    public PrintWriter getReporter() {
+    public PrintWriter getReporter() throws IOException {
         if (outputBuffer.isNew()) {
+            outputBuffer.checkConverter();
             return writer;
         } else {
             return null;


Do you have any test case to prove that this is still an issue? If so, please
attach.

Thanks,

Jan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]