Nelson, Luke wrote:

I tested it and it didn't throw the exception indicated earlier in this thread. I would rather this part of the patch be replaced with something more robust. There really isn't a need to test for the timeout as we should be able to know how the session expired by the session itself providing that information.


Can you please double check, with Tomcat 5, that listeners are properly called when the session expire? This is an are where we are frequently regressing.... I don't have time now to test the patch (will take a look latter today)


-- Jeanfrancois



Luke




-----Original Message-----
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Monday, November 24, 2003 1:49 PM
To: Tomcat Developers List
Subject: Re: cvs commit: jakarta-tomcat-
catalina/catalina/src/share/org/apache/catalina/authenti cator
SingleSignOnEntry.java AuthenticatorBase.java BasicAuthenticator.java
DigestAuthenticator.java FormAuthenticator.java NonLoginAuthenticator.java
SSLAut

Nelson, Luke wrote:



Brian, I believe I just fixed those issues. See the latest patch to
9077.


Did you actually test it ? Your patch calls getLastModified, does this
really work if the session *did* timeout (and as such is no longer valid)
?

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to