Bill Barker wrote:
[EMAIL PROTECTED] wrote:
luehe 2003/10/30 13:01:39
Modified: util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request:
SEVERE: All threads (1) are currently busy, waiting. Increase maxThreads (1) or check the servlet status
and then block forever
-1 for this patch.
1 is obviously a stupid configuration value, so the pool should refuse it.
I agree with Remy: The place to check this is ThreadPool.
I'd like to add that my -1 is not because the patch is bad (the revised algorithm seems ok), but because the 1 value doesn't make sense, so I don't think there's a point adding a special case for it.
I guess I don't understand what makes "1" bad but "2" OK. Where do we draw the line of what is a stupid config?
Jan
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
