Mark Thomas wrote:
On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote:

Remy Maucherat wrote:

I've just committed a very simple implementation of this (without the
extra queryStringEncoding field, although this is not hard to add).
Comments ?

Remy

Thanks for your help with this. I have run through a simple UTF-8 test case and the problem as reported in bug 22666 is still present. I have tracked down what I believe to be the root cause to another part of the Parameters class. I have developed a patch for TC-5 below. I also think that the re-written try block in your patch for the Parameters class can be reverted as it doesn't appear to have any affect for UTF-8 query parameters.

The idea is that it would work if the type of the MB is chars (see processParameters(MB)). So that's why handleQueryParameters attempts to convert the URI to chars. I have reviewed the code, and for some reason which eludes me, toChars didn't set the MB type to chars. So the problem is with MessageBytes, and I have added the missing code.


There are a few things which are weird in those buffer classes. Probably a cleanup will be needed, but later, as this will undoubtedly cause regressions.

Remy



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to