Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:

luehe       2003/08/11 14:44:49
  +    public void setProtocols(String k) {
  +        setAttribute("protocols", k);
  +    }
  +


This probably should be "sslProtocols", no ?

Hmm, but that would make it inconsistent with Http11Protocol's "setProtocol" method, which sets an attribute named "protocol".

Remember I raised this issue after adding the "sslProtocol" property
to CoyoteConnector?

> >>> Added new "sslProtocol" property + minor javadoc edits
> >>>
> >>> The "protocol" property is a little confusing, as it means different
> >>> things in different classes:
> >>>
> >>> - In CoyoteConnector, it refers to the Coyote protocol name (i.e.,
> >>> HTTP/1.1 or AJP/1.3).
> >>>
> >>> - In Http11Processor and CoyoteServerSocketFactory, it refers to the
> >>> SSL protocol variant.
> >>>
> >>> We may want to fix this.
> >>
> >>Well, protocol for HTTP and AJP is the accurate name. Protocol for the
> >>secure layer is also the right name (note that this parameter is
> >>remarkably useless, as everything supports TLS now, and the old SSL2 is
> >>supposedly insecure).



My understanding is that the property names are mapped as follows:


        Connector               Http11Protocol
        --------------------------------------
        sslProtocol(s)    ->    protocol(s)



Jan





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to