DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18251>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18251

ServletResponse.setLocale() is not implemented as described in the spec

           Summary: ServletResponse.setLocale() is not implemented as
                    described in the spec
           Product: Tomcat 5
           Version: 5.0.1
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Connector:Coyote HTTP/1.1
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The setLocale() method in org.apache.coyote.tomcat5.CoyoteResponse is not spec
compliant: it doesn't respect a locale setting after setContentType() has been
called, even if the provided content type doesn't specify a charset.

The Javadocs for setLocale() in Servlet 2.4 PDF2 says:

  Sets the locale of the response, setting the Content-Language header, 
  if the response has not been committed yet. It also sets the response's 
  character encoding appropriately for the locale, if the character encoding
  has not been explicitly set using setContentType(String) or 
  setCharacterEncoding(String) , getWriter hasn’t been called yet, and the 
  response hasn’t been committed yet. ...

CoyoteResponse breaks two of these rules:
1) It doesn't set the Content-Language header (by calling Response.setLocale())
   if setContentType() or setCharacterEncoding() has been called. It should
   make this call in all cases, as long as the response has not been committed.
2) It doesn't set the charset attribute of the Content-Type header (by calling
   Response.setCharacterEncoding()) if setContentType() has been called. It
   should make this call even if setContentType() has been called, as long
   as the specified content type doesn't include a charset attribute.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to