Costin Manolache wrote:
Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:
costin 2003/03/20 07:55:29This time, I don't quite agree.
Modified: catalina/src/share/org/apache/catalina/core
ContainerBase.java
Log:
Fix valve registration.
Few methods to simplify registration.
You'll see a lot of valves ( about 130 with the default webapps ). We
could filter out "trivial" valves - but I would rather leave them in as
an incentive to eliminate some ( and reduce the stack trace size,
memory use, etc :-)
For each servlet we have a pipeline with a single valve - the standard
wrapper valve.
It should be possible to configure per-servlet valves ( not sure how
to do it with server.xml, but with jmx it's not hard ) - but that
doesn't mean we need all this indirections.
For example, there's one valve for status reports, another one for error
page dispatching. This makes things more elegant and flexible. I
understand it eats a big of the max overhead, and eats a negligible
amount of memory, but we shouldn't go that far in optimizing (and
there's far bigger problems to work on, such as request dispatcher
optimization).
I already added code to filter out "trivial" valves.
Yes, it's low priority for most valves.
The mapping valves are not low priority tough: from reading the code it
seems that EngineVavle, HostVavle, etc are still doing the mapping.
For connector backward compatibility, I recommend we keep the mapper code there. That will allow connectors written for Tomcat 4.1.x to continue working with Tomcat 5.
-- Jeanfrancois
Costin
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
