Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valveRemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java

[Remy Maucherat]

Amy Roh wrote:

Amy Roh wrote:
Yes, but IMO, it's the admin's problem. The admin webapp shouldn't
duplicate the functionality that it present elsewhere. Also, if the
admin wishes to disable access from localhost (and access from
elsewhere), then he has the right to do so.

I see your point regarding the admin should let disabling access from
localhost if it's accessing from elsewhere.  How about if I remove checking
for localhost and just keep the checking for admin's own ip and host?

That's probably acceptable. It's not worth the complexity IMO, but it's up to you.

Ok, go to bed now :) It's way too late for you, so I'm not integrating your patches for that tag ;-)

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]