Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/coreStandardValveContext.java ApplicationFilterChain.java ApplicationFilterFactory.javaDummyRequest.java StandardPipeline.java StandardWrapperValve.java

[Remy Maucherat]

Jeanfrancois Arcand wrote:

Hi Remy,

the Administration Tool throw the following exception with your latest change in ApplicationFilterFactory

java.lang.ClassCastException
at org.apache.catalina.core.ApplicationFilterFactory.createFilterChain(ApplicationFilterFactory.java:150)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:713)
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:464)

The problem is at line

+ if (securityManager == null) {
+ Request req = (Request) request;

The request is an instance of org.apache.catalina.core.ApplicationHttpRequest, who extends HttpServletRequestWrapper and who cannot be casted into a Request object (IMBW). I will investigate further....

Any ideas?

I experimented with using an instanceof, as saving an object allocation seems like a good idea. Let me know if there's a problem, and I'll fix it tomorrow (going to bed now; yawn :) ).

Remy


--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>