remm 2002/11/27 12:34:20
Modified: catalina/src/share/org/apache/catalina/core
ApplicationFilterFactory.java
Log:
- Using an instanceof seems worth it to avoid an object creation.
Revision Changes Path
1.5 +5 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationFilterFactory.java
Index: ApplicationFilterFactory.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationFilterFactory.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ApplicationFilterFactory.java 25 Nov 2002 21:03:50 -0000 1.4
+++ ApplicationFilterFactory.java 27 Nov 2002 20:34:20 -0000 1.5
@@ -146,7 +146,7 @@
// Create and initialize a filter chain object
ApplicationFilterChain filterChain = null;
- if (securityManager == null) {
+ if ((securityManager == null) && (request instanceof Request)) {
Request req = (Request) request;
filterChain = (ApplicationFilterChain) req.getFilterChain();
if (filterChain == null) {
@@ -155,6 +155,7 @@
}
} else {
// Security: Do not recycle
+ // Cannot recycle when under a request dispatcher
filterChain = new ApplicationFilterChain();
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
