----- Original Message ----- From: "Ignacio J. Ortega" <[EMAIL PROTECTED]> To: "'Tomcat Developers List'" <[EMAIL PROTECTED]> Sent: Sunday, September 29, 2002 4:43 PM Subject: RE: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apa che/coyote/tomcat4 CoyoteAdapter.java
> > De: Remy Maucherat [mailto:[EMAIL PROTECTED]] > > Enviado el: 29 de septiembre de 2002 21:35 > > > > Well, that particular part of the code was very tricky to get > > right, so > > the change is dangerous by itself. I don't have time to look > > much into > > it (I'll be away for 3 days; someone please handle bugzilla > > during that > > time ;-)). > > Bugs? Who does bugs? :)) I wish more people did bugs. :) > > > > > I think we should implement proxyPort and proxyHost if it > > doesn't work. > > That's supposed to be there, and would solve the problem I think, so > > it's better than trying to change working code. > > > > 12998 and Proxies are related ( they are near in the code :)), but > solving the proxy one doesnt solve the secure flag one, CoyoteAdapter > should make asumptions in the protocol part, it must be protocol > agnostic more channel agnostic too, and when taking the secure flag from > the connector and trying to get proxies from there, it assumes that the > connector knows about wheter the request was in a SSL channel and this > is not true in ajp13 this infos are ont data not the channel nor the > protocol.. > > I doubt redirections has worked ever in JK2, as i said the secure flag > in the CoyoteConnector is never setted, at least my debugger does get to > the breakpoint ever :)) so i can be wrong but in this state is not much > worse that it was.. :)) > ProxyPort should probably be deprecated (at least in 5.0). The 2.4 servlet spec requires that the ServerPort be taken from the Host header, so the ProxyPort isn't that useful anymore. > > Saludos , > Ignacio J. Ortega > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
