Bill Barker wrote: > ----- Original Message ----- > From: <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Wednesday, September 18, 2002 9:44 AM > Subject: cvs commit: > jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 > Http11Processor.java > > > >>bobh 2002/09/18 09:44:35 >> >> Modified: . gump.xml >> coyote/src/java/org/apache/coyote Request.java >> http11/src/java/org/apache/coyote/http11 >> Http11Processor.java >> Log: >> - This associates the socket with the Request. This is so the >> CertificatesValve.verify() can tell where (which socket) the Request >> is comeing from. Without this association, CertificatesValve.verify() >> returns with no SSL Handshake. >> - this change is in part based on feed back from; Vivek N. Yingxian >> Wang (JSSE), Craig M., Qingqing Ouyang >> > > > I'm -1 on this, since having a socket in the Request makes no sense for Jk2. > CertificatesValve is only for use with the deprecated HttpConnector. With > Coyote, the SSL handling has moved to the connector (where it belonged in > the first place).
I agree. I forgot this was done through a notification, and 99% of the code was already there. Thanks for adding the clientauth support and removing the need for hacks. I will revert the changes to Http11Processor and Request. Remy -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
