The tests for Tomcat4 are in jakarta-tomcat-4.0/tester, while the tests for tomcat 5 are in jakarta-tomcat-catalina/tester, so fixing them shouldn't be a problem in that sense.
Howver, since tomcat 4 is now shipping with jasper2, isn't it a problem for tomcat 4, also? In any case, given the lack of depth in this test, I think the right answer is to change it to eliminate the empty tags. I think it's really trying just to see if JSP Document is there as a feature, not really checking the handling of XML. On Wednesday 11 September 2002 06:21 pm, Kin-Man Chung wrote: > I'd suggest that we remove this test. > > Jasper 2 and jasper produces different but correct XML view of the JSP > document. If the golden file is fixed to pass in TC5, it would then > fail in TC4.0. > > > Date: Wed, 11 Sep 2002 18:10:59 -0400 > > From: Steve Downey <[EMAIL PROTECTED]> > > Subject: Catalina tester failure on JSP Document Parsing > > To: [EMAIL PROTECTED] > > > > I'm seeing the following error on catalina's tester app, running it under > > Tomcat 5: > > > > [echo] ----- JSP Document Parsing ----- > > [tester] EXPECTED: ====================================== > > [tester] > > <a>text<b></b></a><a>text<b></b></a><c><d>text</d></c><c><d>text</d></c><e> ><f></ f>text<f></f></e><e><f></f>text<f></f></e> > > > [tester] ================================================ > > [tester] RECEIVED: ====================================== > > [tester] > > <a>text<b/></a><a>text<b/></a><c><d>text</d></c><c><d>text</d></c><e><f/>te >xt<f/ > > ></e><e><f/>text<f/></e> > > [tester] ================================================ > > [tester] FAIL [GET /tester/JspDoc01.jsp HTTP/1.0] Failed Golden File > > Comparison > > > > > > However, I'm not sure the test is actually correct. It's failing because > > of the empty elements being converted from <b></b> to <b/>, and from > > <f></f> to </f>. But, under XML, those are identical ways of saying the > > same thing. > > > > If my analysis is correct, then the golden text needs to be changed, and > > here is a patch for it. Otherwise, there's a deeper problem. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
