DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10418>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10418 logic whether URL needs to be encoded in HttpServletResponse.encodeURL() broken [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX | ------- Additional Comments From [EMAIL PROTECTED] 2002-07-03 08:50 ------- First of all: The paramount should be _not_ to loose a session in any case. Second: It doesn't help, that the client sends _some_ session id; we only can decide that the current session id does not need to be encoded, if it sends _our_ session id. So, you the call isRequestedSessionIdValid() can be replaced by a simple string comparison session.getId().equals(hreq.getRequestedSessionId()). Thats cheap and still the correct behaviour. Third: Anyway, I'd suggest to cache the result of isEncodable() anyway so that we don't have to go through the relative expensive chain of conditions anytime we call encodeURL() -- there can be many of them in applications. Bottomline: fixing this problem is a cheap operation (String.equals()). And caching can enhance this even further. -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
