When cruising the session code I noticed that Sessions are never
recycled because of a small boo boo. Without this patch the
"recycled" ArrayList is always empty.
Can someone verify and patch this in ?
Cheers
-bob
Index: StandardSession.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
retrieving revision 1.28
diff -u -r1.28 StandardSession.java
--- StandardSession.java 1 Mar 2002 19:37:45 -0000 1.28
+++ StandardSession.java 20 Jun 2002 19:22:50 -0000
@@ -768,6 +768,7 @@
expiring = false;
id = null;
lastAccessedTime = 0L;
+ Manager oldManager = manager;
manager = null;
maxInactiveInterval = -1;
notes.clear();
@@ -776,8 +777,8 @@
isValid = false;
// Tell our Manager that this Session has been recycled
- if ((manager != null) && (manager instanceof ManagerBase))
- ((ManagerBase) manager).recycle(this);
+ if ((oldManager != null) && (oldManager instanceof ManagerBase))
+ ((ManagerBase) oldManager).recycle(this);
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
