[EMAIL PROTECTED] wrote:
> There are few bugs in jspc, mostly related with the generation of the 
> class name and the mangling. 

Ooops, sorry, I thought I got it right. At least for the examples 
webapp, it did appear to work good. It is quite hard to un-spaghetti the 
code without beaking anything :-( What is the problem exactly ? (or 
maybe you fixed it already, in which case, just commit the fix :))

> It seems CommandLineCtx and JspEngineContext are almost completely 
> duplicated.

Yes, I was using your refactoring techniques to have them be more and 
more equivalent, until they can be removed. I think we're almost there.

> I did a small change and turned JspCompilationContext into an
> abstract class, with all the code from JspEngineContext that
> deals with marshalling ( and is duplicated in CLCtx ). 
> 
> The abstract methods are those dealing with class loader and with
> getting resources. 
> 
> Is it ok to commit it ? 

+1. I thought about doing it myself ;-)

The goal eventually is to remove the need for having two different 
context classes.

Remy


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to