On 14 Mar 2002 [EMAIL PROTECTED] wrote:
> Date: 14 Mar 2002 23:58:37 -0000
> From: [EMAIL PROTECTED]
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: cvs commit:
> jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup
> ContextConfig.java HostConfig.java LocalStrings.properties
>
> craigmcc 02/03/14 15:58:36
>
> Modified: catalina/src/share/org/apache/catalina/startup
> ContextConfig.java HostConfig.java
> LocalStrings.properties
> Log:
> Refactor the TLD scanning code in ContextConfig to improve clarity, avoid
> redundant parsing of the same TLD, and some wasted effort trying to parse
> a JAR as an XML document (and vice versa) in the old code.
>
> Currently, the jarFile.close() statement to close a JAR file after scanning
> is still commented out (as it was before). Closing the JAR file here seems
> to mess up the WebappClassLoader (which has already included this JAR file
> in its repository of available URLs) by causing "Zip File Is Closed"
> exceptions when it attempts to load classes from that JAR.
>
> In HostConfig, the only change was to close the JAR in a finally block when
> expanding a WAR, even if an exception has occurred.
>
I should have also noted one other functional change -- if an invalid or
missing TLD is encountered, this is now considered fatal to the startup of
the webapp (instead of only being fatal to a JSP page that tries to use
that particular tag library). If this is considered too harsh, it's easy
to undo by removing the "ok = false" statement at line 603.
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
