remm 01/12/17 12:41:00
Modified: catalina/src/share/org/apache/catalina/valves Tag:
tomcat_40_branch ErrorReportValve.java
Log:
- Fix a problem where an exception report thrown from a servlet or a JSP would
not get properly displayed. The bug was caused because sendError now suspends
the response.
Revision Changes Path
No revision
No revision
1.5.2.2 +6 -6
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java
Index: ErrorReportValve.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
retrieving revision 1.5.2.1
retrieving revision 1.5.2.2
diff -u -r1.5.2.1 -r1.5.2.2
--- ErrorReportValve.java 2001/10/04 19:28:13 1.5.2.1
+++ ErrorReportValve.java 2001/12/17 20:41:00 1.5.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
1.5.2.1 2001/10/04 19:28:13 remm Exp $
- * $Revision: 1.5.2.1 $
- * $Date: 2001/10/04 19:28:13 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
1.5.2.2 2001/12/17 20:41:00 remm Exp $
+ * $Revision: 1.5.2.2 $
+ * $Date: 2001/12/17 20:41:00 $
*
* ====================================================================
*
@@ -104,7 +104,7 @@
* @author Craig R. McClanahan
* @author <a href="mailto:[EMAIL PROTECTED]";>Nicola Ken Barozzi</a> Aisa
* @author <a href="mailto:[EMAIL PROTECTED]";>Stefano Mazzocchi</a>
- * @version $Revision: 1.5.2.1 $ $Date: 2001/10/04 19:28:13 $
+ * @version $Revision: 1.5.2.2 $ $Date: 2001/12/17 20:41:00 $
*/
public class ErrorReportValve
@@ -173,8 +173,6 @@
if (sresp.isCommitted())
return;
- response.setSuspended(false);
-
ServletRequest sreq = (ServletRequest) request;
Throwable throwable =
(Throwable) sreq.getAttribute(Globals.EXCEPTION_ATTR);
@@ -197,6 +195,8 @@
(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
}
+
+ response.setSuspended(false);
try {
report(request, response, throwable);
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
