[PATCH] Watchdog-4.0 -- tag_int.jsp tests functionality notmentioned in detail in spec

[Ryan Lubke]

Hi,

The following test:

server/jsp-tests/jsp/tagext/LifeCycle/tag_int.jsp

Is testing functionality not really explained clearly in the
Specification.

****************************
Test code:

<%--
  Test for defining an int variable.
--%>
<%@ taglib uri="/TestLib.tld" prefix="x" %>

<%! public static Integer increment(Integer i) {
         if (i != null)
            return new Integer(i.intValue()+1);
         return new Integer(0);
    }
%>
<%! public static int valueof(Integer i) {
         if (i != null)
            return i.intValue();
         return 0;
    }
%>


<x:define  id="i" scope="page" life="nested" >
(1) i was <%= i %>; <% i = increment(i); %> i is now <%= valueof(i) %>
</x:define>

<x:define  id="i" scope="page" life="nested" >
(2) i was <%= i %>; <% i = increment(i); %> i is now <%= valueof(i) %>
</x:define>

<x:define  id="i" scope="page" life="at_begin" >
(3) i was <%= i %>; <% i = increment(i); %> i is now <%= valueof(i) %>
</x:define>

(4) i was <%= i %>; <% i = increment(i); %> i is now <%= valueof(i) %>

******************************************

GOLDENFILE OUTPUT:
(1) i was null;  i is now 0



(2) i was 0;  i is now 1



(3) i was 0;  i is now 1


(4) i was 0;  i is now 1

**************************************

Issue:

In (3) since the "life" of the variable is described as "at_begin" the
value
should also be available via the PageContext.The value of i is not
synchronized
with the pageContext after the end of the define tag.

Hence in (4) i starts afresh with 0.

Recommendation:

The attached patch excludes the tag_int tests from running until a
clarification is made against the specification.



Index: jsp-gtest.xml
===================================================================
RCS file: /home/cvspublic/jakarta-watchdog-4.0/src/conf/jsp-gtest.xml,v
retrieving revision 1.9
diff -u -r1.9 jsp-gtest.xml
--- jsp-gtest.xml       2001/08/09 17:35:13     1.9
+++ jsp-gtest.xml       2001/11/19 19:53:47
@@ -1585,6 +1585,7 @@
        />
 -->
 
+<!--
       <gtest request="GET /jsp-tests/jsp/tagext/LifeCycle/tag_int.jsp HTTP/1.0"
            debug="0" host="${host}" port="${port}"
            goldenFile="${wgdir}/tagext/LifeCycle/tag_int.html"
@@ -1592,6 +1593,7 @@
           assertion="Test for defining an int variable, specified in the Java Server 
Pages Specification v1.2, Sec 6.4.7"
           testStrategy="testing LifeCycle process"
        />
+-->
 
 <!--
       <gtest request="GET /jsp-tests/jsp/tagext/LifeCycle/tag_nonempty_body_1.jsp 
HTTP/1.0"


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>