cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContextValve.java

[remm]

remm        01/10/05 15:03:53

  Modified:    catalina/src/share/org/apache/catalina/core
                        StandardContextValve.java
  Log:
  - Forgot to remove a finishResponse.
  - Use sendError instead of setStatus (which was probably a hack to avoid committing
    the response).
  - Thanks to Patrick Luby for showing me the bug.
  
  Revision  Changes    Path
  1.14      +10 -11    
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
  
  Index: StandardContextValve.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- StandardContextValve.java 2001/09/26 17:51:07     1.13
  +++ StandardContextValve.java 2001/10/05 22:03:53     1.14
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.13 2001/09/26 17:51:07 remm Exp $
  - * $Revision: 1.13 $
  - * $Date: 2001/09/26 17:51:07 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
 1.14 2001/10/05 22:03:53 remm Exp $
  + * $Revision: 1.14 $
  + * $Date: 2001/10/05 22:03:53 $
    *
    * ====================================================================
    *
  @@ -93,7 +93,7 @@
    * when processing HTTP requests.
    *
    * @author Craig R. McClanahan
  - * @version $Revision: 1.13 $ $Date: 2001/09/26 17:51:07 $
  + * @version $Revision: 1.14 $ $Date: 2001/10/05 22:03:53 $
    */
   
   final class StandardContextValve
  @@ -166,11 +166,6 @@
               relativeURI.startsWith("/META-INF/") ||
               relativeURI.startsWith("/WEB-INF/")) {
               notFound(requestURI, (HttpServletResponse) response.getResponse());
  -            try {
  -                response.finishResponse();
  -            } catch (IOException e) {
  -                ;
  -            }
               return;
           }
   
  @@ -223,9 +218,11 @@
       private void badRequest(String requestURI, HttpServletResponse response) {
   
           try {
  -            response.setStatus(HttpServletResponse.SC_BAD_REQUEST, requestURI);
  +            response.sendError(HttpServletResponse.SC_BAD_REQUEST, requestURI);
           } catch (IllegalStateException e) {
               ;
  +        } catch (IOException e) {
  +            ;
           }
   
       }
  @@ -242,8 +239,10 @@
       private void notFound(String requestURI, HttpServletResponse response) {
   
           try {
  -            response.setStatus(HttpServletResponse.SC_NOT_FOUND, requestURI);
  +            response.sendError(HttpServletResponse.SC_NOT_FOUND, requestURI);
           } catch (IllegalStateException e) {
  +            ;
  +        } catch (IOException e) {
               ;
           }